[ https://issues.apache.org/jira/browse/MESOS-4137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15057100#comment-15057100 ]
Joseph Wu edited comment on MESOS-4137 at 12/15/15 5:22 PM: ------------------------------------------------------------ || Reviews || Summary || | https://reviews.apache.org/r/41294/ | Add {{ContainerLogger}} to {{DockerContainerizer}} | | https://reviews.apache.org/r/41369/ | Add {{ContainerLogger}} to {{mesos-docker-executor}} | | https://reviews.apache.org/r/41370/ | Update {{MesosTest}} | | https://reviews.apache.org/r/41378/ | Update {{DockerContainerizer}} tests | was (Author: kaysoky): || Reviews || Summary || | https://reviews.apache.org/r/41294/ | Add {{ContainerLogger}} to {{DockerContainerizer}} | | https://reviews.apache.org/r/41369/ | Add {{ContainerLogger}} to {{mesos-docker-executor}} | | https://reviews.apache.org/r/41370/ | Update {{MesosTest}} | | https://reviews.apache.org/r/41378/ | Update {{DockerContainerizer}} tests | | https://reviews.apache.org/r/41386/ | Add regression test | > Modularize plain-file logging for executor/task logs launched with the Docker > Containerizer > ------------------------------------------------------------------------------------------- > > Key: MESOS-4137 > URL: https://issues.apache.org/jira/browse/MESOS-4137 > Project: Mesos > Issue Type: Task > Components: docker, modules > Reporter: Joseph Wu > Assignee: Joseph Wu > Labels: logging, mesosphere > > Adding a hook inside the Docker containerizer is slightly more involved than > the Mesos containerizer. > Docker executors/tasks perform plain-file logging in different places > depending on whether the agent is in a Docker container itself > || Agent || Code || > | Not in container | {{DockerContainerizerProcess::launchExecutorProcess}} | > | In container | {{Docker::run}} in a {{mesos-docker-executor}} process | > This means a {{ContainerLogger}} will need to be loaded or hooked into the > {{mesos-docker-executor}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)