[
https://issues.apache.org/jira/browse/MESOS-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074196#comment-15074196
]
Benjamin Hindman edited comment on MESOS-4087 at 12/29/15 7:24 PM:
-------------------------------------------------------------------
{code}
commit 8667c57e28cece7458bac8832918d3b9d5a76acf
Author: Joseph Wu <jos...@mesosphere.io>
Date: Tue Dec 29 10:57:10 2015 -0800
Add test for default container stdout/stderr logging (to sandbox).
`ContainerLoggerTest.DefaultToSandbox` is a regression test which
checks the existing logging behavior, prior to introducing/using the
`ContainerLogger` module. As of this patch, the `ContainerLogger` is
not actually being tested.
Review: https://reviews.apache.org/r/41111
{code}
commit 9b228c566eb597450fd22dd4b940941ba21d4086
Author: Joseph Wu <jos...@mesosphere.io>
Date: Tue Dec 29 10:52:17 2015 -0800
Add container_logger flag to the agent.
`--container_logger` is the container logger module the agent should
use. If unspecified, a `SandboxContainerLogger` is used.
Review: https://reviews.apache.org/r/41061/
commit 6a278f345e4d70fd5c68d0fbda468e8cc2ef6701
Author: Joseph Wu <jos...@mesosphere.io>
Date: Tue Dec 29 10:49:35 2015 -0800
Introduce the ContainerLogger module.
Modularizes the `ContainerLogger` interface and adds the
`SandboxContainerLogger` as the default.
Review: https://reviews.apache.org/r/41004/
commit d37f5a470c12249fbdb525d9ff1b3cb9eb1125f2
Author: Joseph Wu <jos...@mesosphere.io>
Date: Tue Dec 29 10:45:55 2015 -0800
Add default ContainerLogger implementation: SandboxContainerLogger.
This implementation mirrors how executor/task stdout/stderr is
currently saved to plain files.
Review: https://reviews.apache.org/r/41003/
commit a29dd6605fcd35456fdc0583770ec4c79d87de62
Author: Joseph Wu <jos...@mesosphere.io>
Date: Tue Dec 29 10:44:31 2015 -0800
Introduce the ContainerLogger interface.
The container logger is an agent module whose job is to take a
continer's stdout/stderr (i.e., an executor or task's stdout/stderr),
and pipe it to some sink.
Existing container (i.e., executor and task) stdout/stderr are piped
into files caleld "stdout" and "stderr" located in the executor's
sandbox directory. This module aims to encompass this default
behavior as well as allow more sophisticated logging solutions.
Review: https://reviews.apache.org/r/41002/
was (Author: benjaminhindman):
commit 8667c57e28cece7458bac8832918d3b9d5a76acf
Author: Joseph Wu <jos...@mesosphere.io>
Date: Tue Dec 29 10:57:10 2015 -0800
Add test for default container stdout/stderr logging (to sandbox).
`ContainerLoggerTest.DefaultToSandbox` is a regression test which
checks the existing logging behavior, prior to introducing/using the
`ContainerLogger` module. As of this patch, the `ContainerLogger` is
not actually being tested.
Review: https://reviews.apache.org/r/41111
commit 9b228c566eb597450fd22dd4b940941ba21d4086
Author: Joseph Wu <jos...@mesosphere.io>
Date: Tue Dec 29 10:52:17 2015 -0800
Add container_logger flag to the agent.
`--container_logger` is the container logger module the agent should
use. If unspecified, a `SandboxContainerLogger` is used.
Review: https://reviews.apache.org/r/41061/
commit 6a278f345e4d70fd5c68d0fbda468e8cc2ef6701
Author: Joseph Wu <jos...@mesosphere.io>
Date: Tue Dec 29 10:49:35 2015 -0800
Introduce the ContainerLogger module.
Modularizes the `ContainerLogger` interface and adds the
`SandboxContainerLogger` as the default.
Review: https://reviews.apache.org/r/41004/
commit d37f5a470c12249fbdb525d9ff1b3cb9eb1125f2
Author: Joseph Wu <jos...@mesosphere.io>
Date: Tue Dec 29 10:45:55 2015 -0800
Add default ContainerLogger implementation: SandboxContainerLogger.
This implementation mirrors how executor/task stdout/stderr is
currently saved to plain files.
Review: https://reviews.apache.org/r/41003/
commit a29dd6605fcd35456fdc0583770ec4c79d87de62
Author: Joseph Wu <jos...@mesosphere.io>
Date: Tue Dec 29 10:44:31 2015 -0800
Introduce the ContainerLogger interface.
The container logger is an agent module whose job is to take a
continer's stdout/stderr (i.e., an executor or task's stdout/stderr),
and pipe it to some sink.
Existing container (i.e., executor and task) stdout/stderr are piped
into files caleld "stdout" and "stderr" located in the executor's
sandbox directory. This module aims to encompass this default
behavior as well as allow more sophisticated logging solutions.
Review: https://reviews.apache.org/r/41002/
> Introduce a module for logging executor/task output
> ---------------------------------------------------
>
> Key: MESOS-4087
> URL: https://issues.apache.org/jira/browse/MESOS-4087
> Project: Mesos
> Issue Type: Task
> Components: containerization, modules
> Reporter: Joseph Wu
> Assignee: Joseph Wu
> Labels: logging, mesosphere
> Fix For: 0.27.0
>
>
> Existing executor/task logs are logged to files in their sandbox directory,
> with some nuances based on which containerizer is used (see background
> section in linked document).
> A logger for executor/task logs has the following requirements:
> * The logger is given a command to run and must handle the stdout/stderr of
> the command.
> * The handling of stdout/stderr must be resilient across agent failover.
> Logging should not stop if the agent fails.
> * Logs should be readable, presumably via the web UI, or via some other
> module-specific UI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
