[ 
https://issues.apache.org/jira/browse/MESOS-4272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Bannier updated MESOS-4272:
------------------------------------
    Sprint: Mesosphere Sprint 26

> DurationTest.Arithmetic performs inexact float calculation in test
> ------------------------------------------------------------------
>
>                 Key: MESOS-4272
>                 URL: https://issues.apache.org/jira/browse/MESOS-4272
>             Project: Mesos
>          Issue Type: Bug
>          Components: test
>            Reporter: Benjamin Bannier
>            Assignee: Benjamin Bannier
>            Priority: Minor
>
> {{DurationTest.Arithmetic}} does a calculation with not exactly representable 
> floating point values and also performs an equality check,
> {code}
> EXPECT_EQ(Duration::create(3.3).get(), Seconds(10) * 0.33);
> {code}
> Here neither the value {{3.3}} nor {{0.33}} cannot be represented exactly as 
> a floating point number so the check might fail incorrectly (as it does e.g. 
> when compiling and executing the test under 32-bit on Debian8).
> Instead we should just use exactly representable values to make sure the test 
> will succeed as long as the implementation behaves as expected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to