[ 
https://issues.apache.org/jira/browse/MESOS-4571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138257#comment-15138257
 ] 

Shuai Lin commented on MESOS-4571:
----------------------------------

BTW there is another ticket [MESOS-4158] for speed up this test by manipulating 
the clock, so I don't bother with speeding it up here.

> SlaveRecoveryTest.RecoverStatusUpdateManager is not consistent with its 
> description
> -----------------------------------------------------------------------------------
>
>                 Key: MESOS-4571
>                 URL: https://issues.apache.org/jira/browse/MESOS-4571
>             Project: Mesos
>          Issue Type: Improvement
>          Components: tests
>            Reporter: Shuai Lin
>            Assignee: Shuai Lin
>              Labels: newbie++
>
> The description is:
> {code}
> The slave is killed before the update reaches the scheduler. When the slave 
> comes back up it resends the unacknowledged update"
> {code}
> But in the test code, the {{StatusUpdateMessage}} is dropped, so there is no 
> checkpointing for status update involved at all. It's the executor resends 
> the unacknowledged status updates when reconnecting, rather than the slave 
> "resends the unacknowledged update". This means this test is the same with 
> {{SlaveRecoveryTest.ReconnectExecutor}}, which doesn't make sense.
> To fix it, we should drop the {{StatusUpdateAcknowledgementMessage}} instead 
> of the {{StatusUpdateMessage}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to