[ https://issues.apache.org/jira/browse/MESOS-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15141913#comment-15141913 ]
Joseph Wu edited comment on MESOS-4633 at 2/11/16 7:33 PM: ----------------------------------------------------------- || Review || Summary || | https://reviews.apache.org/r/43434/ | Change to {{Option}} | || Discarded below | (decided to take a different approach) | | https://reviews.apache.org/r/43435/ | Change to {{StartSlave}} helper | | https://reviews.apache.org/r/43436/ | Change to {{TestContainerizer}} | | https://reviews.apache.org/r/43437/ https://reviews.apache.org/r/43438/ https://reviews.apache.org/r/43439/ https://reviews.apache.org/r/43440/ https://reviews.apache.org/r/43441/ https://reviews.apache.org/r/43442/ https://reviews.apache.org/r/43444/ https://reviews.apache.org/r/43445/ https://reviews.apache.org/r/43446/ https://reviews.apache.org/r/43447/ https://reviews.apache.org/r/43448/ | Tons and tons of test changes | was (Author: kaysoky): || Review || Summary || | https://reviews.apache.org/r/43434/ | Change to {{Option}} | | https://reviews.apache.org/r/43435/ | Change to {{StartSlave}} helper | | https://reviews.apache.org/r/43436/ | Change to {{TestContainerizer}} | | https://reviews.apache.org/r/43437/ https://reviews.apache.org/r/43438/ https://reviews.apache.org/r/43439/ https://reviews.apache.org/r/43440/ https://reviews.apache.org/r/43441/ https://reviews.apache.org/r/43442/ https://reviews.apache.org/r/43444/ https://reviews.apache.org/r/43445/ https://reviews.apache.org/r/43446/ https://reviews.apache.org/r/43447/ https://reviews.apache.org/r/43448/ | Tons and tons of test changes | > Tests will dereference stack allocated agent objects upon > assertion/expectation failure. > ---------------------------------------------------------------------------------------- > > Key: MESOS-4633 > URL: https://issues.apache.org/jira/browse/MESOS-4633 > Project: Mesos > Issue Type: Bug > Reporter: Joseph Wu > Assignee: Joseph Wu > Labels: flaky, mesosphere, tech-debt, test > > Tests that use the {{StartSlave}} test helper are generally fragile when the > test fails an assert/expect in the middle of the test. This is because the > {{StartSlave}} helper takes raw pointer arguments, which may be > stack-allocated. > In case of an assert failure, the test immediately exits (destroying stack > allocated objects) and proceeds onto test cleanup. The test cleanup may > dereference some of these destroyed objects, leading to a test crash like: > {code} > [18:27:36][Step 8/8] F0204 18:27:35.981302 23085 logging.cpp:64] RAW: Pure > virtual method called > [18:27:36][Step 8/8] @ 0x7f7077055e1c google::LogMessage::Fail() > [18:27:36][Step 8/8] @ 0x7f707705ba6f google::RawLog__() > [18:27:36][Step 8/8] @ 0x7f70760f76c9 __cxa_pure_virtual > [18:27:36][Step 8/8] @ 0xa9423c > mesos::internal::tests::Cluster::Slaves::shutdown() > [18:27:36][Step 8/8] @ 0x1074e45 > mesos::internal::tests::MesosTest::ShutdownSlaves() > [18:27:36][Step 8/8] @ 0x1074de4 > mesos::internal::tests::MesosTest::Shutdown() > [18:27:36][Step 8/8] @ 0x1070ec7 > mesos::internal::tests::MesosTest::TearDown() > {code} > The {{StartSlave}} helper should take {{shared_ptr}} arguments instead. > This also means that we can remove the {{Shutdown}} helper from most of these > tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)