[
https://issues.apache.org/jira/browse/MESOS-4445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15151465#comment-15151465
]
Neil Conway commented on MESOS-4445:
------------------------------------
BTW, https://reviews.apache.org/r/43686/ has some rough data on the performance
impact of using {{unordered_multiset}} in the equality operator for {{Labels}}
(initial impression: performance hit is not significant).
> Labels equality behavior is wrong
> ---------------------------------
>
> Key: MESOS-4445
> URL: https://issues.apache.org/jira/browse/MESOS-4445
> Project: Mesos
> Issue Type: Bug
> Components: general
> Reporter: Neil Conway
> Assignee: Neil Conway
> Priority: Minor
> Labels: labels, mesosphere
>
> {noformat}
> TEST(RevocableResourceTest, LabelSemantics)
> {
> Labels labels1;
> Labels labels2;
> labels1.add_labels()->CopyFrom(createLabel("foo", "bar"));
> labels1.add_labels()->CopyFrom(createLabel("foo", "bar"));
> labels2.add_labels()->CopyFrom(createLabel("foo", "bar"));
> labels2.add_labels()->CopyFrom(createLabel("baz", "qux"));
> bool eq = (labels1 == labels2);
> LOG(INFO) << "Equal? " << (eq ? "true" : "false");
> }
> {noformat}
> Output:
> {noformat}
> [ RUN ] RevocableResourceTest.LabelSemantics
> I0120 13:15:25.207223 2078158848 resources_tests.cpp:1990] Equal? true
> [ OK ] RevocableResourceTest.LabelSemantics (0 ms)
> {noformat}
> This behavior seems pretty problematic.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
