[
https://issues.apache.org/jira/browse/MESOS-4705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186741#comment-15186741
]
Fan Du commented on MESOS-4705:
-------------------------------
I have another thought, look at the perf stat format in differenct kernel
version, it could be either of those:
1. value,event,cgroup
2. value,unit,event,cgroup
3. value,unit,event,cgroup,running,ratio
For old kernel version maintained by OS vendors, the perf stat output elements
don't change its order anyway,
it only append new elements at the end. So why not drop meaningless kernel
version checking, just take the needed elements as
{code}
if tokens.size = 3
return tokens[0] tokens[1] tokens[2]
if tokens.size = 4 or tokens.size = 6
return tokens[0] tokens[2] tokens[3]
{code}
[~bmahler] and [~haosdent] any comments?
> Slave failed to sample container with perf event
> ------------------------------------------------
>
> Key: MESOS-4705
> URL: https://issues.apache.org/jira/browse/MESOS-4705
> Project: Mesos
> Issue Type: Bug
> Components: cgroups, isolation
> Affects Versions: 0.27.1
> Reporter: Fan Du
> Assignee: Fan Du
>
> When sampling container with perf event on Centos7 with kernel
> 3.10.0-123.el7.x86_64, slave complained with below error spew:
> {code}
> E0218 16:32:00.591181 8376 perf_event.cpp:408] Failed to get perf sample:
> Failed to parse perf sample: Failed to parse perf sample line
> '25871993253,,cycles,mesos/5f23ffca-87ed-4ff6-84f2-6ec3d4098ab8,10059827422,100.00':
> Unexpected number of fields
> {code}
> it's caused by the current perf format [assumption |
> https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob;f=src/linux/perf.cpp;h=1c113a2b3f57877e132bbd65e01fb2f045132128;hb=HEAD#l430]
> with kernel version below 3.12
> On 3.10.0-123.el7.x86_64 kernel, the format is with 6 tokens as below:
> value,unit,event,cgroup,running,ratio
> A local modification fixed this error on my test bed, please review this
> ticket.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
