[ 
https://issues.apache.org/jira/browse/MESOS-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15214886#comment-15214886
 ] 

Tomasz Janiszewski commented on MESOS-3243:
-------------------------------------------

I fixed PR. And made two separate commits 
([diff|https://github.com/apache/mesos/compare/077ca9505c533f1c8fcf94e3cc1779d873ab8bea...c4ef738dbdf92fcaaa8724a8246d6f9c7bb85f7f])

1. {{clang-tidy}} 
[077ca9505c533f1c8fcf94e3cc1779d873ab8bea|https://github.com/apache/mesos/commit/077ca9505c533f1c8fcf94e3cc1779d873ab8bea]
2. {{sed}} 
[c4ef738dbdf92fcaaa8724a8246d6f9c7bb85f7f|https://github.com/apache/mesos/commit/c4ef738dbdf92fcaaa8724a8246d6f9c7bb85f7f]



Should I open new review and post them one by one?

> Replace NULL with nullptr
> -------------------------
>
>                 Key: MESOS-3243
>                 URL: https://issues.apache.org/jira/browse/MESOS-3243
>             Project: Mesos
>          Issue Type: Improvement
>            Reporter: Michael Park
>            Assignee: Tomasz Janiszewski
>
> As part of the C++ upgrade, it would be nice to move our use of {{NULL}} over 
> to use {{nullptr}}. I think it would be an interesting exercise to do this 
> with {{clang-modernize}} using the [nullptr 
> transform|http://clang.llvm.org/extra/UseNullptrTransform.html] (although 
> it's probably just as easy to use {{sed}}).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to