[
https://issues.apache.org/jira/browse/MESOS-5131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15233311#comment-15233311
]
Guangya Liu commented on MESOS-5131:
------------------------------------
One question, how does the resource estimator report some non-revocable
resources to master? Seems at
https://github.com/apache/mesos/blob/18f60da868b07885fc2c29b4494054dd9bc871a6/src/slave/slave.cpp#L4980
, the agent only check the revocable resources from resources estimator.
> DRF allocator crashes master with CHECK when resource is incorrect
> ------------------------------------------------------------------
>
> Key: MESOS-5131
> URL: https://issues.apache.org/jira/browse/MESOS-5131
> Project: Mesos
> Issue Type: Bug
> Components: allocation, oversubscription
> Reporter: Zhitao Li
> Assignee: Zhitao Li
> Priority: Critical
>
> We were testing a custom resource estimator which broadcasts oversubscribed
> resources, but they are not marked as "revocable".
> This unfortunately triggered the following check in hierarchical allocator:
> {quote}
> void HierarchicalAllocatorProcess::updateSlave(
> // Check that all the oversubscribed resources are revocable.
> CHECK_EQ(oversubscribed, oversubscribed.revocable());
> {quote}
> This definitely shouldn't happen in production cluster. IMO, we should do
> both of following:
> 1. Make sure incorrect resource is not sent from agent (even crash agent
> process is better);
> 2. Decline agent registration if it's resources is incorrect, or even tell it
> to shutdown, and possibly remove this check.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
