[ https://issues.apache.org/jira/browse/MESOS-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240235#comment-15240235 ]
Vinod Kone commented on MESOS-3558: ----------------------------------- I've committed the chain. Thanks for the hard work! I am keeping this issue open so that you can send a final review with the tests I requested. {code} commit 124a05b4fe650ddd1ff08e2a616fe4ee4ba8bd5f Author: Qian Zhang <zhang...@cn.ibm.com> Date: Wed Apr 13 15:55:34 2016 -0700 Updated tests for HTTP command executor. Review: https://reviews.apache.org/r/45670/ commit df24b6700aa79448782eab6277039d9129f9a17e Author: Qian Zhang <zhang...@cn.ibm.com> Date: Wed Apr 13 15:55:29 2016 -0700 Added --http_command_executor flag. Review: https://reviews.apache.org/r/44427/ commit bec4d711c3fc190138d100023bba9e3fe087052e Author: Qian Zhang <zhang...@cn.ibm.com> Date: Wed Apr 13 15:55:25 2016 -0700 Updated http_command_executor.cpp to use v1 API. Review: https://reviews.apache.org/r/44424/ commit ed304030fc5a36d1c1f13e505d6b56f928a81cd4 Author: Qian Zhang <zhang...@cn.ibm.com> Date: Wed Apr 13 15:55:21 2016 -0700 Added HTTP command executor to make files. Added HTTP command executor to make files. For now the content in http_command_executor.cpp is identical to executor.cpp, and it will be updated in the subsequent review. Review: https://reviews.apache.org/r/44423/ {code} > Implement HTTPCommandExecutor that uses the Executor Library > -------------------------------------------------------------- > > Key: MESOS-3558 > URL: https://issues.apache.org/jira/browse/MESOS-3558 > Project: Mesos > Issue Type: Task > Reporter: Anand Mazumdar > Assignee: Qian Zhang > Labels: mesosphere > > Instead of using the {{MesosExecutorDriver}} , we should make the > {{CommandExecutor}} in {{src/launcher/executor.cpp}} use the new Executor > HTTP Library that we create in {{MESOS-3550}}. > This would act as a good validation of the {{HTTP API}} implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)