[ 
https://issues.apache.org/jira/browse/MESOS-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256080#comment-15256080
 ] 

Jay Guo commented on MESOS-5269:
--------------------------------

Since {{hashmap<std::string, Shared<Metric> > metrics}} expects a _string_ 
(_metric.name_) as the key to avoid duplicated metrics, we probably need 
something like this:
{code}
Gauge(const std::string& primaryName, const std::vector<std::string>& aliases = 
None(), const Deferred<Future<double>()>& f)
  : Metric(primaryName, aliases, None()), data(new Data(f)) {}
{code}

Let me know what you think.

> Replace Master/Slave Terminology Phase I - Update Metrics
> ---------------------------------------------------------
>
>                 Key: MESOS-5269
>                 URL: https://issues.apache.org/jira/browse/MESOS-5269
>             Project: Mesos
>          Issue Type: Task
>            Reporter: Jay Guo
>
>   process::metrics::Gauge slaves_connected;
>   process::metrics::Gauge slaves_disconnected;
>   process::metrics::Gauge slaves_active;
>   process::metrics::Gauge slaves_inactive;
>   process::metrics::Counter messages_register_slave;
>   process::metrics::Counter messages_reregister_slave;
>   process::metrics::Counter messages_unregister_slave;
>   process::metrics::Counter messages_update_slave;
>   process::metrics::Counter recovery_slave_removals;
>   process::metrics::Counter slave_registrations;
>   process::metrics::Counter slave_reregistrations;
>   process::metrics::Counter slave_removals;
>   process::metrics::Counter slave_removals_reason_unhealthy;
>   process::metrics::Counter slave_removals_reason_unregistered;
>   process::metrics::Counter slave_removals_reason_registered;
>   process::metrics::Counter slave_shutdowns_scheduled;
>   process::metrics::Counter slave_shutdowns_completed;
>   process::metrics::Counter slave_shutdowns_canceled;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to