[ https://issues.apache.org/jira/browse/MESOS-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Klues updated MESOS-5435: ------------------------------- Story Points: 1 > Add default implementations to all Isolator virtual functions > ------------------------------------------------------------- > > Key: MESOS-5435 > URL: https://issues.apache.org/jira/browse/MESOS-5435 > Project: Mesos > Issue Type: Improvement > Reporter: Kevin Klues > Assignee: Kevin Klues > Fix For: 0.29.0 > > > Currently, all of the virtual functions in `mesos::slave::Isolator` are pure > virtual (expect status()). For many isolators, however, it doesn't make sense > to implement all of these virtual functions. Each isolator has to provide its > own default implementation of these functions even if they aren't really > relying on them. This adds unnecessary extra code to many isolators that > don't need them. > Moreover, the `MesosIsolatorProcess` has the same problem for each of its > virtual functions. > We should provide defaults for these instead of making each and every > isolator implement even in cases when it doesn't make sense. -- This message was sent by Atlassian JIRA (v6.3.4#6332)