[
https://issues.apache.org/jira/browse/MESOS-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15325674#comment-15325674
]
Klaus Ma edited comment on MESOS-5600 at 6/11/16 3:22 AM:
----------------------------------------------------------
It's not only about {{total}}; in {{sort()}}, it will update the order of
client based on share: in {{DRFSorter::update}}, the weight is updated which
will impact the result of {{DRFSorter::calculateShare}}.
was (Author: klaus1982):
It's not only about {{total}}; in {{sort()}}, it will update the order of
client based on share: in {{DRFSorter::update}}, the weight is updated which
will impact the result of {{DRFSorter::calculateShare}}; in
{{DRFSorter::remove}}, the client was removed, {{sort()}} should not return
removed clients.
> "dirty" was never set back as false in sorter
> ---------------------------------------------
>
> Key: MESOS-5600
> URL: https://issues.apache.org/jira/browse/MESOS-5600
> Project: Mesos
> Issue Type: Bug
> Components: allocation
> Reporter: Guangya Liu
> Assignee: Guangya Liu
>
> dirty was set as true when the total resource was updated in the cluster, but
> it was never set back as false. The dirty should be set back as false in
> DRFSorter::sort
> https://github.com/apache/mesos/blob/master/src/master/allocator/sorter/drf/sorter.cpp#L320-L334
> The reason that we cannot detect this is because once an agent was added to
> cluster, the dirty will be set as true and the sorter will always call sort()
> to calculate share for each framework, this will impact the performance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
