[
https://issues.apache.org/jira/browse/MESOS-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15328452#comment-15328452
]
Benjamin Mahler edited comment on MESOS-5581 at 6/13/16 10:36 PM:
------------------------------------------------------------------
Regression is fixed here:
{noformat}
commit 9dc9669d3cf884cb96e2a0cb68d8fa55e203bde1
Author: Benjamin Mahler <bmah...@apache.org>
Date: Mon Jun 13 13:59:18 2016 -0700
Fixed a regression in the creation of the isolator modules.
While refactoring the isolator creation in 6fb9c024, we introduced a
regression in that isolator modules were no longer being created via
the --isolation flag values.
Also, we need to re-establish the old semantics that allowed the
operator to control the isolator ordering. A TODO has been added
for this.
Review: https://reviews.apache.org/r/48662
{noformat}
After some discussion with [~jieyu], I left a TODO to restore the ability for
operators to express the isolator ordering. This will require us to
de-centralize the ordering constraints so that each isolator is responsible for
validating its ordering within the {{--isolation}} flag:
{code}
// TODO(bmahler): De-centralize the ordering enforcement so that
// each isolator is responsible for validating that it is
// ordered correctly within the --isolation flag. This gives the
// operator control over the isolator ordering. If the operator
// specifies an invalid ordering, it will produce an error
// during the creation of an isolator and we will inform the
// operator to adjust the --isolation flag accordingly.
{code}
was (Author: bmahler):
After some discussion with [~jieyu], I left a TODO to restore the ability for
operators to express the isolator ordering. This will require us to
de-centralize the ordering constraints so that each isolator is responsible for
validating its ordering within the {{--isolation}} flag:
{code}
// TODO(bmahler): De-centralize the ordering enforcement so that
// each isolator is responsible for validating that it is
// ordered correctly within the --isolation flag. This gives the
// operator control over the isolator ordering. If the operator
// specifies an invalid ordering, it will produce an error
// during the creation of an isolator and we will inform the
// operator to adjust the --isolation flag accordingly.
{code}
> Guarantee ordering between Isolators
> ------------------------------------
>
> Key: MESOS-5581
> URL: https://issues.apache.org/jira/browse/MESOS-5581
> Project: Mesos
> Issue Type: Improvement
> Reporter: Kevin Klues
> Assignee: Kevin Klues
> Labels: isolator, mesosphere
> Fix For: 1.0.0
>
>
> Some isolators depend on other isolators. However, we currently do not have a
> generic method of expressing these dependencies. We special case the
> `filesystem/*` isolators to make sure that dependencies on them are
> satisfied, but no other dependencies can be expressed.
>
> Instead, we should use a vector to represent the pairing of isolator name to
> isolator creator function. This way, the relative dependencies between each
> isolator will be implicit in the ordering of the vector. Currently, a hashmap
> is used to hold this pairing, but this is inadequate because hashmaps are
> inherently unordered. The new implementation using a vector will ensure
> everything is processed in the order it is listed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
