[ https://issues.apache.org/jira/browse/MESOS-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373622#comment-15373622 ]
Joseph Wu commented on MESOS-5835: ---------------------------------- Note: On Windows, the patch command seems to require the {{--binary}} option, but not always. The HTTP parser tarball patch needs {{--binary}}, but the Zookeeper patch will fail given {{--binary}}. See the mistake I made here: https://github.com/apache/mesos/commit/8cbc1aeffbbed1adc0a136740af821a7c6c9f83a And reverted here: https://github.com/apache/mesos/commit/bc7edb36d9d617321c9f8e9ff82301027fa6fe02 > Audit `PATCH_CMD`; make sure all patches are being applied on Windows. > ---------------------------------------------------------------------- > > Key: MESOS-5835 > URL: https://issues.apache.org/jira/browse/MESOS-5835 > Project: Mesos > Issue Type: Bug > Components: cmake > Reporter: Alex Clemmer > Assignee: Alex Clemmer > Labels: cmake, mesosphere > > A quick perusal of 3rdparty/CMakelists.txt seems to indicate that we're not > patching a lot of the libraries on Windows. We should (1) record this > decision as a comment if they are not necessary, or add the relevant commands > if they are, and (2) fix the `PATCH_CMD` function to account for Windows as > well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)