[
https://issues.apache.org/jira/browse/MESOS-6303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anand Mazumdar updated MESOS-6303:
----------------------------------
Description: Currently, the {{received}} callback for the [Scheduler
library |
https://github.com/apache/mesos/blob/master/include/mesos/scheduler/scheduler.hpp]
returns a {{queue}} of events which makes sense semantically. However, this
also means that callers have to inherently copy the queue object by value due
to looping on all the events and invoking {{pop()}} on the queue (it can't be a
const reference). We should consider changing it to {{list}} or {{vector}} to
avoid the extra copying if this is a performance bottle-neck. (was: Currently,
the {{received}} callback for the Scheduler library returns a {{queue}} of
events which makes sense semantically. However, this also means that callers
have to inherently copy the queue object by value due to looping on all the
events and invoking {{pop()}} on the queue (it can't be a const reference). We
should consider changing it to {{list}} or {{vector}} to avoid the extra
copying if this is a performance bottle-neck.)
> Consider changing the scheduler library received callback to be a vector/list
> of events.
> ----------------------------------------------------------------------------------------
>
> Key: MESOS-6303
> URL: https://issues.apache.org/jira/browse/MESOS-6303
> Project: Mesos
> Issue Type: Improvement
> Reporter: Anand Mazumdar
> Labels: mesosphere
>
> Currently, the {{received}} callback for the [Scheduler library |
> https://github.com/apache/mesos/blob/master/include/mesos/scheduler/scheduler.hpp]
> returns a {{queue}} of events which makes sense semantically. However, this
> also means that callers have to inherently copy the queue object by value due
> to looping on all the events and invoking {{pop()}} on the queue (it can't be
> a const reference). We should consider changing it to {{list}} or {{vector}}
> to avoid the extra copying if this is a performance bottle-neck.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
