[ 
https://issues.apache.org/jira/browse/MESOS-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15687422#comment-15687422
 ] 

Greg Mann edited comment on MESOS-5658 at 11/22/16 6:00 PM:
------------------------------------------------------------

Part of this ticket was addressed as part of MESOS-5966.

The following review adds a {{how}} parameter to {{Socket::shutdown}}: 
https://reviews.apache.org/r/53804/

A TODO was also added to consider changing/removing the default shutdown mode.


was (Author: greggomann):
This ticket was addressed as part of MESOS-5966.

The following review adds a {{how}} parameter to {{Socket::shutdown}}: 
https://reviews.apache.org/r/53804/

> Socket::shutdown() is inconsistent with BSD sockets API
> -------------------------------------------------------
>
>                 Key: MESOS-5658
>                 URL: https://issues.apache.org/jira/browse/MESOS-5658
>             Project: Mesos
>          Issue Type: Improvement
>          Components: libprocess
>            Reporter: Neil Conway
>            Assignee: Greg Mann
>            Priority: Minor
>
> In libprocess, the {{Socket::shutdown()}} member function is inconsistent 
> with the {{shutdown(2)}} function from the Berkeley sockets API: the former 
> doesn't take any parameters (and implicitly *only* shuts down the 
> receiver-side of the socket), whereas the latter takes a parameter that 
> controls which side(s) are shutdown.
> IMO we should either make these behave the same or document why they are 
> different.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to