[ https://issues.apache.org/jira/browse/MESOS-6661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15712678#comment-15712678 ]
Andrew Blanchard edited comment on MESOS-6661 at 12/1/16 6:31 PM: ------------------------------------------------------------------ That makes perfect, sense. I did not realize that additional key/values were included in the {{draining_machines}} list. Setting the "statuses" key would certainly help make it more clear. Alternatively, it might make sense to include some other information in the {{down_machines}} list. Perhaps a timestamp of when the machine was set to "down", since that may differ from the scheduled start time in the maintenance window. edit: granted, that would be a bit more of an involved change.. was (Author: blancharda): That makes perfect, sense. I did not realize that additional key/values were included in the {{draining_machines}} list. Setting the "statuses" key would certainly help make it more clear. Alternatively, it might make sense to include some other information in the {{down_machines}} list. Perhaps a timestamp of when the machine was set to "down", since that may differ from the scheduled start time in the maintenance window. > maintenance status page has inconsistent formatting > --------------------------------------------------- > > Key: MESOS-6661 > URL: https://issues.apache.org/jira/browse/MESOS-6661 > Project: Mesos > Issue Type: Bug > Components: HTTP API > Affects Versions: 1.0.1 > Environment: Mesos Version: 1.01 > OS: Ubuntu 16.04 (both on the client and cluster nodes) > HTTP Interface: Chrome browser > Reporter: Andrew Blanchard > Priority: Trivial > Labels: formatting, http > > *Description*: > The MachineID lists on the /maintenance/status page are formatted > differently. Specifically, with one machine `down` and one machine > `draining`, the page is formatted as shown below. Note that the > `draining_machines` list has a label ("id") on the machine ID. This > formatting extends to multiple items in each respective list. > {code:xml} > { > "down_machines": [ > { > "hostname": "agent2", > "ip": "172.17.0.2" > } > ], > "draining_machines": [ > { > "id": { > "hostname": "agent3", > "ip": "172.17.0.3" > } > } > ] > } > {code} > *Steps to reproduce*: > # Add two agents to the maintenance schedule > # Move one agent to the down state > # View the status page at <masterIP:port>/maintenance/status > *Proposed solution*: > Unify the format. Either way is fine - personally I would prefer them to both > be in the current form of `down_machines` with no label on the MachineIDs - > but regardless, they should be the same. -- This message was sent by Atlassian JIRA (v6.3.4#6332)