[
https://issues.apache.org/jira/browse/MESOS-6717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15737005#comment-15737005
]
Joseph Wu commented on MESOS-6717:
----------------------------------
{code}
commit ca0a8d552cd098593c3c3b0f76d5215846de7120
Author: Alex Clemmer <clemmer.alexan...@gmail.com>
Date: Thu Dec 8 17:25:06 2016 -0800
Stout: Added logic for TMPDIR environment variable in `os::temp`.
`TMPDIR` is a POSIX-standard environment variable which can be used
to specify a temporary directory. This variable is currently read
in the agent tests, but ignored in other parts of the codebase.
(`os::temp` is commonly used by `os::mkdtemp`.)
This commit is one of two commits that will normalize the location
of the temporary directory.
Review: https://reviews.apache.org/r/54489/
{code}
{code}
commit 883f5d2e31eb3f73e808e58c020f5b68ca7b2e1d
Author: Alex Clemmer <clemmer.alexan...@gmail.com>
Date: Thu Dec 8 17:38:41 2016 -0800
Normalized how temporary directories are determined in tests.
This changes the Mesos tests to use the updated `os::temp` helper,
which (on POSIX) now checks the `TMPDIR` environment variable.
On Windows, this changes the temporary directory to an appropriate
location (`/tmp` does not exist on Windows by default).
Review: https://reviews.apache.org/r/54490/
{code}
{code}
commit 3511b5407710e9a0d0a668ce1663a8d89cc028ca
Author: Joseph Wu <josep...@apache.org>
Date: Fri Dec 9 17:50:38 2016 -0800
Removed the UUID from IO Switchboard tests.
The IO switchboard server creates a UNIX socket at a given path.
Due to OS constraints, this path must be less than 104 characters long.
In the tests, the path is set to a value based on the test directory.
If the test directory is too long, the UNIX socket creation will fail,
as observed in OSX, where the standard temporary directory does not
default to `/tmp` (as is the case on most Linux's).
The test directory was changed to provide platform-specific values
in this review:
https://reviews.apache.org/r/54490/
This commit shortens the UNIX socket address by removing the UUID.
This is safe because we are not running multiple IO switchboards
in the same test, in the same directory.
{code}
> Add Windows support to agent test harness
> -----------------------------------------
>
> Key: MESOS-6717
> URL: https://issues.apache.org/jira/browse/MESOS-6717
> Project: Mesos
> Issue Type: Bug
> Components: agent
> Reporter: Alex Clemmer
> Assignee: Alex Clemmer
> Priority: Blocker
> Labels: microsoft, windows-mvp
>
> Of particular interest is in `src/tests/CMakeLists.txt` is support enough of
> the following that we can successfully run agent tests:
> TEST_HELPER_SRC
> MESOS_TESTS_UTILS_SRC
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
