[ https://issues.apache.org/jira/browse/MESOS-7138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yan Xu updated MESOS-7138: -------------------------- Summary: Check invariants in `Sorter::update`. (was: Implement the ) > Check invariants in `Sorter::update`. > ------------------------------------- > > Key: MESOS-7138 > URL: https://issues.apache.org/jira/browse/MESOS-7138 > Project: Mesos > Issue Type: Task > Reporter: Yan Xu > > This JIRA tracks the implementation of this > [TODO|https://github.com/apache/mesos/blob/54b4d69b4b34c0d527cf53f1e436cb16ed50ac05/src/master/allocator/sorter/drf/sorter.cpp#L205-L208]: > {quote} > // TODO(bmahler): Check invariants between old and new allocations. > // Namely, the roles and quantities of resources should be the same! > // Otherwise, we need to ensure we re-calculate the shares, as > // is being currently done, for safety. > {quote} > After this check, we can remove the line that sets the sorter to be {{dirty}} > after this call and we can avoid an unnecessary sort. > Note that the shared resources feature currently assumes the invariants. -- This message was sent by Atlassian JIRA (v6.3.15#6346)