[
https://issues.apache.org/jira/browse/MESOS-7368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975127#comment-15975127
]
Dmitriy Shirchenko commented on MESOS-7368:
-------------------------------------------
For reference, after Mesos version was bumped to 1.2.0, Aurora patches produce
fatal errors since `-Werror` is used.
Output from: https://reviews.apache.org/r/57487/
{code}
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java:250:
warning: [deprecation] hasRole() in FrameworkInfo has been deprecated
&& (!frameworkInfoFactory.getFrameworkInfo().hasRole()
^
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java:251:
warning: [deprecation] getRole() in FrameworkInfo has been deprecated
|| frameworkInfoFactory.getFrameworkInfo().getRole().isEmpty())) {
^
error: warnings found and -Werror specified
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java:400:
warning: [deprecation] getRole() in FrameworkInfo has been deprecated
.setRole(frameworkInfoFactory.getFrameworkInfo().getRole())
^
1 error
3 warnings
FAILED
FAILURE: Build failed with an exception.
{code}
Of course, it's possible to add override deprecation notices, but this adds
tech debt and would be great to just have at least one correct way of setting
roles for frameworks available in 1.2.0.
> Documentation of framework role(s) in proto definition is confusing
> -------------------------------------------------------------------
>
> Key: MESOS-7368
> URL: https://issues.apache.org/jira/browse/MESOS-7368
> Project: Mesos
> Issue Type: Bug
> Affects Versions: 1.2.0
> Reporter: Benjamin Bannier
>
> The documentation for role-related fields in {{FrameworkInfo}} is confusing:
> the {{role}} field is marked as {{deprecated}} while the {{roles}} field is
> marked as {{EXPERIMENTAL}} and has an additional {{NOTE}} advising to not use
> this field.
> This leaves users confused what field they should use in their code.
> Depending on how the proto definition is used {{deprecated}} might even
> produce (fatal) errors, while {{roles}} seems strongly discouraged.
> We should clean this up to make sure users always know which field they
> should use.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
