[ https://issues.apache.org/jira/browse/MESOS-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001156#comment-16001156 ]
Till Toenshoff edited comment on MESOS-7429 at 5/8/17 10:02 PM: ---------------------------------------------------------------- 1.4.0 (master): {noformat} commit 3742945b37f5ba1003128ccc5a864b08756b80b8 Author: Till Toenshoff <toensh...@me.com> Date: Mon May 8 22:19:29 2017 +0200 Added MESOS-7429 to 1.3.1 CHANGELOG. commit 226a3a43a495a9d56075ab537494008243cf3bdb Author: Till Toenshoff <toensh...@me.com> Date: Mon May 8 23:06:08 2017 +0200 Added MESOS-7429 to 1.2.1 CHANGELOG. commit b53c5d3a598f0b7bf6fa7eda1f35dee0db00e082 Author: Till Toenshoff <toensh...@me.com> Date: Mon May 8 19:16:54 2017 +0200 Updated runtime isolators to use new task_environment member. Review: https://reviews.apache.org/r/58925/ commit 1973ab59f731cb7c44c2abfc851567f3b9e6555a Author: Till Toenshoff <toensh...@me.com> Date: Mon May 8 19:15:57 2017 +0200 Updated containerizer for isolator task_environment merge. Review: https://reviews.apache.org/r/58924/ commit c3130bd56d6a691da8c561e7acc739fe5fd87564 Author: Till Toenshoff <toensh...@me.com> Date: Mon May 8 19:15:29 2017 +0200 Added new ContainerLaunchInfo task_environment. Review: https://reviews.apache.org/r/58923/ {noformat} Further backports pending.... stay tuned. was (Author: tillt): 1.4.0 (master): {noformat} commit b53c5d3a598f0b7bf6fa7eda1f35dee0db00e082 Author: Till Toenshoff <toensh...@me.com> Date: Mon May 8 19:16:54 2017 +0200 Updated runtime isolators to use new task_environment member. Review: https://reviews.apache.org/r/58925/ commit 1973ab59f731cb7c44c2abfc851567f3b9e6555a Author: Till Toenshoff <toensh...@me.com> Date: Mon May 8 19:15:57 2017 +0200 Updated containerizer for isolator task_environment merge. Review: https://reviews.apache.org/r/58924/ commit c3130bd56d6a691da8c561e7acc739fe5fd87564 Author: Till Toenshoff <toensh...@me.com> Date: Mon May 8 19:15:29 2017 +0200 Added new ContainerLaunchInfo task_environment. Review: https://reviews.apache.org/r/58923/ {noformat} Further backports pending.... stay tuned. > Allow isolators to inject task-specific environment variables. > -------------------------------------------------------------- > > Key: MESOS-7429 > URL: https://issues.apache.org/jira/browse/MESOS-7429 > Project: Mesos > Issue Type: Improvement > Affects Versions: 1.2.0 > Reporter: Till Toenshoff > Assignee: Till Toenshoff > Labels: containerizer, isolator, mesosphere > Fix For: 1.4.0 > > > For command tasks, we currently have no way for isolators to inject task > specific environments into data path. > Isolators in their {{prepare}} implementation can return a > {{ContainerLaunchInfo}} which currently supports setting the member > {{environment}} - but that is effective for the executor already and will get > inherited by the task environment. > Given that the command-executor is active in the host-fs context but the task > may be running in a container-fs context ({{has_rootfs=true}}), using the > above will possibly cause failures, depending on the nature of the variables > set -- consider e.g. {{LD_LIBRARY_PATH}} as a fatal one. > The command-executor does support the flag {{task_environment}} to receive > environment variables which are meant exclusively for the task itself but not > the executor. > Runtime isolators (docker/runtime, appc/runtime) already make use of this > flag. However, they do it in a way that is a bit unfortunate as it does not > allow for other isolators to make use of it - there is no merging taking > place in the containerizer. -- This message was sent by Atlassian JIRA (v6.3.15#6346)