[
https://issues.apache.org/jira/browse/MESOS-7343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016360#comment-16016360
]
Joseph Wu commented on MESOS-7343:
----------------------------------
{code}
commit 7acec00b6aefa43b89bee3fa66579b2eded56af4
Author: Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Date: Thu May 18 12:56:42 2017 -0700
Windows: Fixed apply-reviews.py to retain line feeds.
Write using 'wb' instead of 'w' for binary mode. This writes the
downloaded patch file exactly as it came, instead of treating as text
and changing line endings. This resolves a bug where `git apply` doesn't
always work with CRLF endings in patch files.
Review: https://reviews.apache.org/r/59293/
{code}
> Add a ReviewBot for testing patches on Windows
> ----------------------------------------------
>
> Key: MESOS-7343
> URL: https://issues.apache.org/jira/browse/MESOS-7343
> Project: Mesos
> Issue Type: Improvement
> Components: reviewbot
> Environment: Windows 10
> Reporter: Andrew Schwartzmeyer
> Assignee: Andrew Schwartzmeyer
> Labels: microsoft, windows
> Fix For: 1.4.0
>
>
> A major hindrance to development of Mesos for Windows is that, since the
> platform support is so new, no tests their patches on Windows. Frequently
> this causes upstream commits to master to break the Windows build (a recent
> notable occasion was commit 5f159cdcb), which interrupts Windows developers
> (read: me) in order to fix the build. Much of the problem is due to broken
> processes failing to catch human error.
> One process we can immediately fix is the ReviewBot, which tests uploaded
> patches for Ubuntu. Adding the same functionality but for Windows will go a
> long way toward preventing upstream build breaks.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
