[ https://issues.apache.org/jira/browse/MESOS-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046889#comment-16046889 ]
Benjamin Mahler commented on MESOS-6972: ---------------------------------------- [~dzhuk] I see, sounds like we have two options that depend on the install handler implementation. One case is const-access style, in which arenas and const access are best, and the other is wanting to move out the data from the protobuf, in which case non-const access (for moveability) with no arenas is best. > Improve performance of protobuf message passing by removing RepeatedPtrField > to vector conversion. > -------------------------------------------------------------------------------------------------- > > Key: MESOS-6972 > URL: https://issues.apache.org/jira/browse/MESOS-6972 > Project: Mesos > Issue Type: Improvement > Reporter: Benjamin Mahler > Labels: tech-debt > > Currently, all protobuf message handlers must take a {{vector}} for repeated > fields, rather than a {{RepeatedPtrField}}. > This requires that a copy be performed of the repeated field's entries (see > [here|https://github.com/apache/mesos/blob/9228ebc239dac42825390bebc72053dbf3ae7b09/3rdparty/libprocess/include/process/protobuf.hpp#L78-L87]), > which can be very expensive in some cases. We should avoid requiring this > expense on the callers. -- This message was sent by Atlassian JIRA (v6.4.14#64029)