[ 
https://issues.apache.org/jira/browse/MESOS-7643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125054#comment-16125054
 ] 

James Peach commented on MESOS-7643:
------------------------------------

[~gilbert] [~jieyu][~qianzhang] Please note 
https://reviews.apache.org/r/60764/, which fixes a number of issues in isolator 
dependency checking but heavily depends on converting the isolations into a 
hash set.


> The order of isolators provided in '--isolation' flag is not preserved and 
> instead sorted alphabetically
> --------------------------------------------------------------------------------------------------------
>
>                 Key: MESOS-7643
>                 URL: https://issues.apache.org/jira/browse/MESOS-7643
>             Project: Mesos
>          Issue Type: Bug
>          Components: containerization
>    Affects Versions: 1.1.2, 1.2.0, 1.3.0
>            Reporter: Michael Cherny
>            Assignee: Gilbert Song
>            Priority: Critical
>              Labels: isolation
>
> According to documentation and comments in code the order of the entries in 
> the --isolation flag should specify the ordering of the isolators. 
> Specifically, the
> `create` and `prepare` calls for each isolator should run serially in the 
> order in which they appear in the --isolation flag, while the `cleanup` call 
> should be serialized in reverse order (with exception of filesystem isolator 
> which is always first).
> But in fact, the isolators provided in '--isolation' flag are sorted 
> alphabetically.
> That happens in [this line of 
> code|https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/containerizer.cpp#L377].
>  In this line use of 'set<string>' is done (apparently instead of list or 
> vector) and set is a sorted container.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to