[ 
https://issues.apache.org/jira/browse/MESOS-6918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136119#comment-16136119
 ] 

Benjamin Mahler commented on MESOS-6918:
----------------------------------------

[~jpe...@apache.org] [~xujyan] ideally you could shepherd but with my feedback 
involved, I do want to see what the changes to the existing metrics code / 
functionality will be. I'll include some thoughts here:

# I'm a little confused about the relationship between the enum type and a 
"multi-metric" type like {{Timer}}, where {{Timer}} includes some sub-metrics 
that are counters and some sub-metrics that are gauges, the current patches 
seem to express a single type for {{Timer}} which feels off.
# There seems to be a breaking change to the timer metric that expresses the 
most recent measurement, probably that one needs to be deprecated in place of a 
{{/total_time}} or we should rationalize why it's ok to change the meaning 
(maybe it's ok, not sure).

Those are the main things that I haven't spent enough time to come up with 
suggestions for, haven't looked at the endpoint change yet.

> Prometheus exporter endpoints for metrics
> -----------------------------------------
>
>                 Key: MESOS-6918
>                 URL: https://issues.apache.org/jira/browse/MESOS-6918
>             Project: Mesos
>          Issue Type: Bug
>          Components: statistics
>            Reporter: James Peach
>            Assignee: James Peach
>
> There are a couple of [Prometheus|https://prometheus.io] metrics exporters 
> for Mesos, of varying quality. Since the Mesos stats system actually knows 
> about statistics data types and semantics, and Mesos has reasonable HTTP 
> support we could add Prometheus metrics endpoints to directly expose 
> statistics in [Prometheus wire 
> format|https://prometheus.io/docs/instrumenting/exposition_formats/], 
> removing the need for operators to run separate exporter processes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to