[ https://issues.apache.org/jira/browse/MESOS-6428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143878#comment-16143878 ]
Andrei Budnik commented on MESOS-6428: -------------------------------------- https://reviews.apache.org/r/61800/ > Mesos containerizer helper function signalSafeWriteStatus is not AS-Safe > ------------------------------------------------------------------------ > > Key: MESOS-6428 > URL: https://issues.apache.org/jira/browse/MESOS-6428 > Project: Mesos > Issue Type: Bug > Components: containerization > Affects Versions: 1.1.0 > Reporter: Benjamin Bannier > Assignee: Jing Chen > Labels: newbie, tech-debt > > In {{src/slave/containerizer/mesos/launch.cpp}} a helper function > {{signalSafeWriteStatus}} is defined. Its name seems to suggest that this > function is safe to call in e.g., signal handlers, and it is used in this > file's {{signalHandler}} for exactly that purpose. > Currently this function is not AS-Safe since it e.g., allocates memory via > construction of {{string}} instances, and might destructively modify > {{errno}}. > We should clean up this function to be in fact AS-Safe. -- This message was sent by Atlassian JIRA (v6.4.14#64029)