[ 
https://issues.apache.org/jira/browse/MESOS-3644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16193848#comment-16193848
 ] 

Andrew Schwartzmeyer commented on MESOS-3644:
---------------------------------------------

In fact, the only use of it that I could find at a glance is:

{noformat}
src/logging/logging.cpp
100:    os::signals::reset(signal);

3rdparty/libprocess/src/subprocess.cpp
148:    if (os::signals::install(SIGTERM, &signalHandler) != 0) {

src/slave/containerizer/mesos/launch.cpp
204:    if (os::signals::install(i, signalHandler) != 0 && i < posixLimit) {

3rdparty/libprocess/src/tests/main.cpp
97:  os::signals::reset(SIGTERM);

src/slave/containerizer/mesos/io/switchboard_main.cpp
114:  if (os::signals::install(SIGTERM, sigtermHandler) != 0) {

3rdparty/stout/include/stout/os/signals.hpp
27:  if (os::signals::internal::Suppressor suppressor ## signal = \
28:      os::signals::internal::Suppressor(signal))

3rdparty/stout/include/stout/os/posix/signals.hpp
110:    pending = signals::pending(signal);
115:      unblock = signals::block(signal);
128:    if (!pending && signals::pending(signal)) {
167:      signals::unblock(signal);
{noformat}

The only signal that has a handler installed for it is {{SIGTERM}}... which is 
weird because you don't _generally_ want to handle this on Linux either 
({{SIGINT}} would be more appropriate). But neither of these signals are used 
on Windows.

While you can manually {{raise}} a signal on Windows, Ctrl-C will _not_ send 
{{SIGINT}}, and killing the process will _not_ send {{SIGTERM}}.

There does not appear to be a need to implement this on Windows.

> Implement stout/os/windows/signals.hpp
> --------------------------------------
>
>                 Key: MESOS-3644
>                 URL: https://issues.apache.org/jira/browse/MESOS-3644
>             Project: Mesos
>          Issue Type: Task
>          Components: stout
>            Reporter: Alex Clemmer
>            Assignee: Andrew Schwartzmeyer
>            Priority: Minor
>              Labels: mesosphere, windows
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to