[ https://issues.apache.org/jira/browse/MESOS-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279050#comment-16279050 ]
Michael Park edited comment on MESOS-6972 at 12/5/17 7:02 PM: -------------------------------------------------------------- {noformat} commit c9462f4927cfffb1f3a90827467ded730c0f40b9 Author: Dmitry Zhuk dz...@twopensource.com Date: Tue Dec 5 10:11:28 2017 -0800 Migrated to use the `EventConsumer` interface. Review: https://reviews.apache.org/r/63632/ {noformat} {noformat} commit 6b91f62769a1f8c525162fc716b1d5c231c77811 Author: Dmitry Zhuk dz...@twopensource.com Date: Tue Dec 5 10:11:23 2017 -0800 Separated `Event` visitation and consumption. This introduces the `EventConsumer` interface, which add support of `Event`s with move-only data. This allows consumers to move data out of `Event`, rather than copying it. This is required to implement move-only objects support in `defer` to guarantee that deferred function object is invoked only once, allowing deferred parameters to be moved into call. Review: https://reviews.apache.org/r/63631/ {noformat} {noformat} commit 1074a9c3fd7aa9d2e4b484f86dbe657271abecc0 Author: Dmitry Zhuk dz...@twopensource.com Date: Tue Dec 5 07:23:28 2017 -0800 Fixed the signature of `CallableOnce::operator()`. This changes `operator()` signature to match the one defined in `CallableOnce` template parameter. Previously used form incorrectly specifies that `operator()` can be invoked with arbitrary number and types of parameters, which can break other templates using SFINAE to check if function object can be invoked with specific parameters. Review: https://reviews.apache.org/r/64337/ {noformat} was (Author: mcypark): {noformat} commit c9462f4927cfffb1f3a90827467ded730c0f40b9 Author: Dmitry Zhuk dz...@twopensource.com Date: Tue Dec 5 10:11:28 2017 -0800 Migrated to use the `EventConsumer` interface. Review: https://reviews.apache.org/r/63632/ {noformat} {noformat} commit 6b91f62769a1f8c525162fc716b1d5c231c77811 Author: Dmitry Zhuk dz...@twopensource.com Date: Tue Dec 5 10:11:23 2017 -0800 Separated `Event` visitation and consumption. This introduces the `EventConsumer` interface, which add support of `Event`s with move-only data. This allows consumers to move data out of `Event`, rather than copying it. This is required to implement move-only objects support in `defer` to guarantee that deferred function object is invoked only once, allowing deferred parameters to be moved into call. Review: https://reviews.apache.org/r/63631/ {noformat} {noformat} commit 1074a9c3fd7aa9d2e4b484f86dbe657271abecc0 Author: Dmitry Zhuk dz...@twopensource.com Date: Tue Dec 5 07:23:28 2017 -0800 Fixed the signature of `CallableOnce::operator()`. This changes `operator()` signature to match the one defined in `CallableOnce` template parameter. Previously used form incorrectly specifies that `operator()` can be invoked with arbitrary number and types of parameters, which can break other templates using SFINAE to check if function object can be invoked with specific parameters. Review: https://reviews.apache.org/r/64337/ {noformat} > Improve performance of protobuf message passing by removing RepeatedPtrField > to vector conversion. > -------------------------------------------------------------------------------------------------- > > Key: MESOS-6972 > URL: https://issues.apache.org/jira/browse/MESOS-6972 > Project: Mesos > Issue Type: Improvement > Reporter: Benjamin Mahler > Labels: performance, tech-debt > > Currently, all protobuf message handlers must take a {{vector}} for repeated > fields, rather than a {{RepeatedPtrField}}. > This requires that a copy be performed of the repeated field's entries (see > [here|https://github.com/apache/mesos/blob/9228ebc239dac42825390bebc72053dbf3ae7b09/3rdparty/libprocess/include/process/protobuf.hpp#L78-L87]), > which can be very expensive in some cases. We should avoid requiring this > expense on the callers. -- This message was sent by Atlassian JIRA (v6.4.14#64029)