[ https://issues.apache.org/jira/browse/MESOS-7016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329715#comment-16329715 ]
James Peach edited comment on MESOS-7016 at 1/22/18 4:08 PM: ------------------------------------------------------------- | [r/65201|https://reviews.apache.org/r/65201] | Added a global DEFAULT_TEST_TIMEOUT variable. | | [r/65202|https://reviews.apache.org/*r/65202] | Adopted the libprocess `DEFAULT_TEST_TIMEOUT`. | was (Author: jamespeach): | [r/65201|https://reviews.apache.org/r/65201] | Added a global DEFAULT_TEST_TIMEOUT variable. | | [*r/65202|https://reviews.apache.org/*r/65202] | Adopted the libprocess `DEFAULT_TEST_TIMEOUT`. | > Make default AWAIT_* duration configurable > ------------------------------------------ > > Key: MESOS-7016 > URL: https://issues.apache.org/jira/browse/MESOS-7016 > Project: Mesos > Issue Type: Improvement > Components: libprocess, test > Reporter: Benjamin Bannier > Assignee: James Peach > Priority: Major > Fix For: 1.6.0 > > > libprocess defines a number of helpers {{AWAIT_*}} to wait for a > {{process::Future}} reaching terminal states. These helpers are used in tests. > Currently the default duration to wait before triggering an assertion failure > is 15s. This value was chosen as a compromise between failing fast on likely > fast developer machines, but also allowing enough time for tests to pass in > high-contention environments (e.g., overbooked CI machines). > If a machine is more overloaded than expected, {{Futures}} might take longer > to reach the desired state, and tests could fail. Ultimately we should > consider running tests with paused clock to eliminate this source of test > flakiness, see MESOS-4101, but as an intermediate measure we should make the > default timeout duration configurable. > A simple approach might be to expose a build variable allowing users to set > at configure/cmake time a desired timeout duration for the setup they are > building for. This would allow us to define longer timeouts in the CI build > scripts, while keeping default timeouts as short as possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)