[ https://issues.apache.org/jira/browse/MESOS-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388702#comment-16388702 ]
Andrew Schwartzmeyer commented on MESOS-7342: --------------------------------------------- commit ca357e95f Author: Akash Gupta <akash-gu...@hotmail.com> Date: Tue Mar 6 13:11:19 2018 -0800 Windows: Fixed `WIFEXITED` and `WIFSIGNALED` stubs. The `WIFEXITED` and `WIFSIGNALED` macros were incorrectly checking if the exit code was not -1 to determine if the process exited or was signaled. However, -1 is a valid return code on Windows, so when logic like `CHECK(WIFEXITED(status)|| WIFSIGNALED(status))` was used, it would end up aborting the process accidentally. For `WIFEXITED`, we simply return `true` because all error codes on Windows indicate the process exited (if the process instead failed to spawn, then `os::spawn()` would return `None()` instead of an exit code). For `WIFIGNALED`, we simply return `false` for similar reasons. We assume the process did not exit due to a signal, as that is not an expected scenario on Windows. Review: https://reviews.apache.org/r/65840/ > Port Docker tests > ----------------- > > Key: MESOS-7342 > URL: https://issues.apache.org/jira/browse/MESOS-7342 > Project: Mesos > Issue Type: Bug > Reporter: Andrew Schwartzmeyer > Assignee: Akash Gupta > Priority: Major > Labels: docker, windows > > While one of Daniel Pravat's last acts was introducing the the Docker > containerizer for Windows, we don't have tests. We need to port > `docker_tests.cpp` and `docker_containerizer_tests.cpp` to Windows. -- This message was sent by Atlassian JIRA (v7.6.3#76005)