[ https://issues.apache.org/jira/browse/MESOS-8714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410015#comment-16410015 ]
Andrei Budnik commented on MESOS-8714: -------------------------------------- Composing c'zer [subscribes|https://github.com/apache/mesos/blob/5b655ce062ff55cdefed119d97ad923aeeb2efb5/src/slave/containerizer/composing.cpp#L356-L357] on container termination after successful launch. So we always clean up this hash map. After changes in composing c'zer, this invariant (that we always clean up terminated containers) should remain unchanged. I think that there should be only one place, where we do cleanup: `ComposingContainerizerProcess::_launch`. > Cleanup `containers_` hashmap once container exits > -------------------------------------------------- > > Key: MESOS-8714 > URL: https://issues.apache.org/jira/browse/MESOS-8714 > Project: Mesos > Issue Type: Task > Reporter: Andrei Budnik > Priority: Major > > To clean up a `containers_` hash map in composing c'zer, we need to subscribe > on a container termination event in `_launch` method. Also, it's desirable to > limit the number of places where we do the clean up. -- This message was sent by Atlassian JIRA (v7.6.3#76005)