[
https://issues.apache.org/jira/browse/MESOS-7397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16537742#comment-16537742
]
Andrew Schwartzmeyer commented on MESOS-7397:
---------------------------------------------
Ah, I see. You want the behavior I mentioned here:
https://issues.apache.org/jira/browse/MESOS-8586?focusedCommentId=16381296&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16381296
That you can use apply-reviews on reviews that _are_ submitted, but are not
already applied to the current tree. So we'd need something like -f to make
apply-reviews ignore that Review Board says the review is submitted, and then
attempt to apply it anyway, and then make sure any errors from Git applying the
review are emitted correctly.
Question though: why do you want this? If the review has already been
submitted, then it exists not as a review any more, but as a commit, in the Git
repo, so you can just git cherry-pick at your leisure. I _personally_ think
that apply-reviews should deal only with Review Board reviews, not Git commits.
> apply-reviews.py silently fails when using chain mode.
> ------------------------------------------------------
>
> Key: MESOS-7397
> URL: https://issues.apache.org/jira/browse/MESOS-7397
> Project: Mesos
> Issue Type: Bug
> Reporter: Till Toenshoff
> Priority: Minor
>
> When using {{apply-reviews.py}} in chain mode {{--chain}} it suppresses error
> messages when patches do not apply.
> Example on {{1.0.x}}:
> {noformat}
> $ ./support/apply-reviews.py -c -r 57764
> $
> {noformat}
> If used without chain mode, the error message is properly displayed:
> {noformat}
> $ ./support/apply-reviews.py -r 57764
> 2017-04-18 11:45:58 URL:https://reviews.apache.org/r/57764/diff/raw/
> [1067/1067] -> "57764.patch" [1]
> error: patch failed: src/launcher/posix/executor.cpp:116
> error: src/launcher/posix/executor.cpp: patch does not apply
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
