[ 
https://issues.apache.org/jira/browse/MESOS-9075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543702#comment-16543702
 ] 

Kevin Klues commented on MESOS-9075:
------------------------------------

{noformat}
commit 6936fb553b463b99bf4bc07de9067dd9ca16457a
Author: Armand Grillet <[email protected]>
Date:   Fri Jul 13 22:21:00 2018 +0200

    Fixed linting errors that appear with the recently updated pylint.
    
    As part of this, we needed to remove some unnecessary delegate to
    'super' calls that are legal in python2 but not in python3. That said,
    they are also unnecessary in python2 so we remove them in both cases.
    
    Specifically, we previously used to override 'main()' in our Python and
    JS linters with:
    
        def main(self, modified_files):
            super(PyLinter, self).main(modified_files)
    
        def main(self, modified_files):
            super(JsLinter, self).main(modified_files)
    
    However, in python3 this gives us linting errors because such a
    delegation is unecessary. Just using the 'main()' function from the base
    class is sufficient.
    
    Review: http://reviews.apache.org/r/67910/
{noformat}

> Virtualenv management in support directory is buggy.
> ----------------------------------------------------
>
>                 Key: MESOS-9075
>                 URL: https://issues.apache.org/jira/browse/MESOS-9075
>             Project: Mesos
>          Issue Type: Bug
>    Affects Versions: 1.7.0
>            Reporter: Armand Grillet
>            Assignee: Armand Grillet
>            Priority: Major
>             Fix For: 1.7.0
>
>
> When switching back and forth from Python 2 to 3, the virtualenv does not get 
> correctly reinstalled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to