[ https://issues.apache.org/jira/browse/MESOS-895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16624201#comment-16624201 ]
James Peach edited comment on MESOS-895 at 9/21/18 9:21 PM: ------------------------------------------------------------ {noformat} commit 0b9861e356ec2d7d50163ae54a6be9c1c45f279b Author: James Peach <jpe...@apache.org> Date: Fri Sep 21 14:13:29 2018 -0700 Removed bundled libev patch. Since we now disable the libev SIGCHLD handler at runtime, we no longer need to bundle the patch to do it at build time. It is still useful to bundle libev itself, to support older distributions. Review: https://reviews.apache.org/r/68800/ {noformat} was (Author: jamespeach): {noformat} commit 0b9861e356ec2d7d50163ae54a6be9c1c45f279b Author: James Peach <jpe...@apache.org\> Date: Fri Sep 21 14:13:29 2018 -0700 Removed bundled libev patch. Since we now disable the libev SIGCHLD handler at runtime, we no longer need to bundle the patch to do it at build time. It is still useful to bundle libev itself, to support older distributions. Review: https://reviews.apache.org/r/68800/ {noformat} > Unbundle libev. > --------------- > > Key: MESOS-895 > URL: https://issues.apache.org/jira/browse/MESOS-895 > Project: Mesos > Issue Type: Bug > Affects Versions: 0.17.0 > Reporter: Timothy St. Clair > Assignee: James Peach > Priority: Major > Labels: tech-debt > > The libev patch can easily be removed and update the configuration flags and > possibly the accompanying code prior to include. > For configure pass in: > CFLAGS=-DEV_CHILD_ENABLE=0 > For inclusion: > #define EV_CHILD_ENABLE 0 > include <ev.h> > excerpt from maintainer: > <schmorp> that patch is unnecessary > <tstclair> schmorp, so if they wanted to just set EV_CHILD_ENABLE=0 they > could just pass CFLAGS=-DEV_CHILD_ENABLE=0 through. > <schmorp> tstclair: yes, or use a wrapper -- This message was sent by Atlassian JIRA (v7.6.3#76005)