[
https://issues.apache.org/jira/browse/MESOS-9459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16731363#comment-16731363
]
Vinod Kone commented on MESOS-9459:
-----------------------------------
I see this error in CI.
{noformat}
=============================================
Error response from daemon: conflict: unable to delete e895c0531b9a (cannot be
forced) - image is being used by running container cf8595802408
git rev-parse HEAD
git clean -fd
git reset --hard 1e8ebcb8cf1710052c1ae14e342c1277616fa13d
Traceback (most recent call last):
File
"/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
line 341, in <module>
main()
File
"/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
line 329, in main
review_requests = api(review_requests_url)
File
"/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
line 119, in api
return json.loads(urllib.request.urlopen(url, data=data).read())
File "/usr/lib/python3.5/json/__init__.py", line 312, in loads
s.__class__.__name__))
TypeError: the JSON object must be str, not 'bytes'
Build step 'Execute shell' marked build as failure
Sending e-mails to: [email protected]
{noformat}
> Reviewbot is not verifying reviews that need verification
> ---------------------------------------------------------
>
> Key: MESOS-9459
> URL: https://issues.apache.org/jira/browse/MESOS-9459
> Project: Mesos
> Issue Type: Bug
> Affects Versions: 1.8.0
> Reporter: Vinod Kone
> Assignee: Armand Grillet
> Priority: Major
> Labels: ci, integration
> Fix For: 1.8.0
>
>
> For example this run of ReviewBot
> https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Reviewbot/23594/console
> says that there are no reviews to be verified, which is false because if we
> look at ReviewBoard there are a bunch of reviews that have not been commented
> on by ReviewBot since a new diff has been posted.
> {noformat}
> 12-05-18_23:41:54 - Running
> /home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py
> 0 review requests need verification
> {noformat}
> I see the the logic of the verify-reviews.py script was changed as part of
> the python3 transition here: https://reviews.apache.org/r/68619/diff/1#27
> which likely caused the bug.
> As an aside, It's unfortunate that python3 update was bundled with logic
> changes in this review. cc [~andschwa]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
