[ 
https://issues.apache.org/jira/browse/MESOS-8470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16732153#comment-16732153
 ] 

Benjamin Bannier commented on MESOS-8470:
-----------------------------------------

[~vinodkone], this patch has landed in 1.8.0. We choose to tighten validation 
of framework IDs used in resubscription which while only enforcing existing 
expectations could lead to certain invalid and broken use cases to be 
completely rejected. This makes me feel like we should not backport this patch 
as some might consider this as an API break.

> CHECK failure in DRFSorter due to invalid framework id.
> -------------------------------------------------------
>
>                 Key: MESOS-8470
>                 URL: https://issues.apache.org/jira/browse/MESOS-8470
>             Project: Mesos
>          Issue Type: Bug
>          Components: allocation
>            Reporter: Chun-Hung Hsiao
>            Assignee: Benjamin Bannier
>            Priority: Major
>              Labels: allocator, mesosphere, techdebt
>
> A framework registering with a custom {{FrameworkID}} containing slashes such 
> as {{/foo/bar}} will trigger a CHECK failure at 
> https://github.com/apache/mesos/blob/177a2221496a2caa5ad25e71c9982ca3eed02fd4/src/master/allocator/sorter/drf/sorter.cpp#L167:
> {noformat}
> master.cpp:6618] Updating info for framework /foo/bar 
> sorter.cpp:167] Check failed: clientPath == current->clientPath() (/foo/bar 
> vs. foo/bar)
> {noformat}
> The sorter should be defensive with any {{FrameworkID}} containing slashes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to