[
https://issues.apache.org/jira/browse/MESOS-6632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763727#comment-16763727
]
Andrei Budnik commented on MESOS-6632:
--------------------------------------
https://reviews.apache.org/r/69684/
> ContainerLogger might leak FD if container launch fails.
> --------------------------------------------------------
>
> Key: MESOS-6632
> URL: https://issues.apache.org/jira/browse/MESOS-6632
> Project: Mesos
> Issue Type: Bug
> Components: containerization
> Affects Versions: 0.28.2, 1.0.1, 1.1.0
> Reporter: Jie Yu
> Priority: Critical
>
> In MesosContainerizer, if logger->prepare() succeeds but its continuation
> fails, the pipe fd allocated in the logger will get leaked. We cannot add a
> destructor in ContainerLogger::SubprocessInfo to close the fd because
> subprocess might close the OWNED fd.
> A FD abstraction might help here. In other words, subprocess will no longer
> be responsible for closing external FDs, instead, the FD destructor will be
> doing so.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
