[ https://issues.apache.org/jira/browse/MESOS-9544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16765696#comment-16765696 ]
Chun-Hung Hsiao commented on MESOS-9544: ---------------------------------------- I've paused the development of the {{RecoverPublishedVolumeFailed}} test. I have some WIP patches and plan to integrate them into MESOS-8745, then we can use the {{GET_RESOURCE_PROVIDRES}} call to verify the resource provider recovery failure in the test. > SLRP does not clean up destroyed persistent volumes. > ---------------------------------------------------- > > Key: MESOS-9544 > URL: https://issues.apache.org/jira/browse/MESOS-9544 > Project: Mesos > Issue Type: Bug > Components: storage > Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.6.0, 1.6.1, 1.7.0, 1.7.1 > Reporter: Chun-Hung Hsiao > Assignee: Chun-Hung Hsiao > Priority: Blocker > Labels: mesosphere, mesosphere-dss-beta, storage > > When a persistent volume created on a {{ROOT}} disk is destroyed, the agent > will clean up its data: > https://github.com/apache/mesos/blob/f44535bca811720fc272c9abad2bc78652d61fe3/src/slave/slave.cpp#L4397 > However, this is not the case for PVs on SLRP disks. The agent relies on the > SLRP to do the cleanup: > https://github.com/apache/mesos/blob/f44535bca811720fc272c9abad2bc78652d61fe3/src/slave/slave.cpp#L4472 > But SLRP simply updates its metadata and do nothing: > https://github.com/apache/mesos/blob/f44535bca811720fc272c9abad2bc78652d61fe3/src/resource_provider/storage/provider.cpp#L2805 > This would lead to data leakage if the framework does not call `CREATE_DISK` > but just unreserve it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)