[ 
https://issues.apache.org/jira/browse/MESOS-9159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817969#comment-16817969
 ] 

Qian Zhang commented on MESOS-9159:
-----------------------------------

Backported to 1.5.x:
commit 0a5e6f639cbc8c1fd0aafb430a3aeebe8c4765fb
Author: Liangyu Zhao <[email protected]>
Date:   Wed Aug 29 13:52:18 2018 -0700

    Windows: Add comment about V2S2 Docker image Manifest.
    
    Review: https://reviews.apache.org/r/68562/

 src/uri/fetchers/docker.cpp | 5 +++++
 1 file changed, 5 insertions(+)

commit ae439072764e1be9229abec8c60d7a4fd45e7416
Author: Liangyu Zhao <[email protected]>
Date:   Wed Aug 29 11:54:47 2018 -0700

    Windows: Enabled `DockerFetcherPluginTest` suite.
    
    Enabled `Internet` test environment on Windows. Disabled `Internet`
    `HealthCheckTests` on Windows, since they require complete
    development. Modified `DockerFetcherPluginTest` to fetch
    `microsoft/nanoserver` for more extensive test for fetcher on Windows.
    
    Review: https://reviews.apache.org/r/67930/

 src/tests/environment.cpp        |  5 ++++-
 src/tests/health_check_tests.cpp | 10 ++++++----
 src/tests/uri_fetcher_tests.cpp  | 81 
++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------
 3 files changed, 62 insertions(+), 34 deletions(-)

commit f11b0b2c4c5f4f752603d15c573c353409bf12c9
Author: Liangyu Zhao <[email protected]>
Date:   Wed Aug 29 11:54:25 2018 -0700

    Windows: Enable DockerFetcher in Windows agent.
    
    Review: https://reviews.apache.org/r/68455/

 src/CMakeLists.txt                              | 13 ++++++-------
 src/slave/containerizer/mesos/containerizer.cpp |  2 ++
 src/uri/fetcher.cpp                             |  6 +++---
 src/uri/fetcher.hpp                             | 10 +++++-----
 4 files changed, 16 insertions(+), 15 deletions(-)

commit f82f6e35e91d603dd74b5e4ffbf74a72eac7c611
Author: Liangyu Zhao <[email protected]>
Date:   Tue Aug 28 17:08:59 2018 -0700

    Windows: Fetch blobs with V2S2 Docker image manifest.
    
    DockerFetcher now fetches both V2S1 and V2S2 manifests to save on
    disk when agent is running on Windows. Linux part of the code in
    agent is unchanged. In addition to fetching from DockerHub,
    DockerFetcher now supports fetching from foreign URLs provided in
    V2S2 Docker image manifest.
    
    Review: https://reviews.apache.org/r/68454/

 src/uri/fetchers/docker.cpp | 364 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------
 src/uri/fetchers/docker.hpp |   4 ++
 2 files changed, 319 insertions(+), 49 deletions(-)

commit e068da28fcdac66c1a4654d818f43407906f6bb3
Author: Liangyu Zhao <[email protected]>
Date:   Tue Aug 28 13:32:17 2018 -0700

    Windows: Parse version 2 schema 2 Docker image manifest.
    
    Added support to parse V2S2 Docker image manifest
    (https://docs.docker.com/registry/spec/manifest-v2-2/). Adopted the
    validation code from patch 53850.
    
    Review: https://reviews.apache.org/r/68451/

 include/mesos/docker/spec.hpp                 |  18 ++++++++++++++++++
 include/mesos/docker/v2_2.hpp                 |  23 +++++++++++++++++++++++
 include/mesos/docker/v2_2.proto               |  45 
+++++++++++++++++++++++++++++++++++++++++++++
 src/CMakeLists.txt                            |   1 +
 src/Makefile.am                               |  11 +++++++++--
 src/docker/spec.cpp                           |  66 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 src/tests/CMakeLists.txt                      |   2 +-
 src/tests/containerizer/docker_spec_tests.cpp | 121 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 8 files changed, 284 insertions(+), 3 deletions(-)

commit 2f7b68c5cd83f8274014aec036b07f8b5c748490
Author: Liangyu Zhao <[email protected]>
Date:   Tue Aug 28 13:30:42 2018 -0700

    Windows: Update curl version to 7.61.0.
    
    A bug is encountered in version 7.57.0, and is fixed in 7.61.0.
    
    Review: https://reviews.apache.org/r/68450/

 3rdparty/CMakeLists.txt       | 2 +-
 3rdparty/cmake/Versions.cmake | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

> Support Foreign URLs in docker registry puller
> ----------------------------------------------
>
>                 Key: MESOS-9159
>                 URL: https://issues.apache.org/jira/browse/MESOS-9159
>             Project: Mesos
>          Issue Type: Task
>            Reporter: Akash Gupta
>            Assignee: Liangyu Zhao
>            Priority: Major
>             Fix For: 1.4.4, 1.5.4, 1.6.3, 1.7.3, 1.8.0
>
>
> Currently, trying to pull the layers of a Windows image with the current 
> registry pull code will return a 404 error. This is because the Windows 
> docker images need to pull the base OS layers from the foreign URLs field in 
> the version 2 schema 2 docker manifest. As a result, the register puller 
> needs to be aware of version 2 schema 2 and the foreign urls field.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to