[ 
https://issues.apache.org/jira/browse/MESOS-9743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825847#comment-16825847
 ] 

Jan Schlicht commented on MESOS-9743:
-------------------------------------

cc [~asekretenko]
Looks like this change was intended? In https://reviews.apache.org/r/70387/ the 
imported location is changed from {{glog}} to {{libglog}}, i.e. from a static 
to a dynamic library. In that case, it's probably related to the Ninja build 
system and a byproduct isn't copied. But then, building with 
{{BUILD_SHARED_LIBS=ON}} will cause problems, because GLog would be build as 
static lib and we expect a dynamic library now.

> Argument forwaring in CMake build result in glog 0.4.0 build as shared library
> ------------------------------------------------------------------------------
>
>                 Key: MESOS-9743
>                 URL: https://issues.apache.org/jira/browse/MESOS-9743
>             Project: Mesos
>          Issue Type: Bug
>          Components: cmake
>    Affects Versions: 1.8.0
>         Environment: macOS 10.14.4, clang 8.0.0, Ninja build system
>            Reporter: Jan Schlicht
>            Assignee: Jan Schlicht
>            Priority: Major
>              Labels: build, easyfix, mesosphere, triaged
>
> GLog versions >= 0.3.5 introduces a {{BUILD_SHARED_LIBS}} CMake option. The 
> CMake configuration of Mesos also has such an option. Because these options 
> are forwarded to third-party packages, GLog will be build as a shared library 
> if Mesos is build with {{BUILD_SHARED_LIBS=OFF}}. This is not intended, as in 
> that case the GLog shared library is not copied over, resulting in Mesos 
> binaries failing to start.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to