[
https://issues.apache.org/jira/browse/MESOS-9695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830263#comment-16830263
]
Andrei Budnik commented on MESOS-9695:
--------------------------------------
{code:java}
commit c8004ee8a0962d0e0f9147718853160bb708f5bc
Author: Qian Zhang <[email protected]>
Date: Tue Apr 30 13:23:26 2019 +0200
Removed the duplicate pid check in Docker containerizer.
Review: https://reviews.apache.org/r/70561/
{code}
> Remove the duplicate pid check in Docker containerizer
> ------------------------------------------------------
>
> Key: MESOS-9695
> URL: https://issues.apache.org/jira/browse/MESOS-9695
> Project: Mesos
> Issue Type: Improvement
> Components: containerization
> Reporter: Qian Zhang
> Assignee: Qian Zhang
> Priority: Major
> Labels: containerization
>
> In `DockerContainerizerProcess::_recover`, we check if there are two
> executors use duplicate pid, and error out if we find duplicate pid (see
> [here|https://github.com/apache/mesos/blob/1.7.2/src/slave/containerizer/docker.cpp#L1068:L1078]
> for details). However I do not see the value this check can give us but it
> will cause serious issue (agent crash loop when restarting) in rare case (a
> new executor reuse pid of an old executor), so I think we'd better to remove
> it from Docker containerizer.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
