[
https://issues.apache.org/jira/browse/MESOS-9762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16831878#comment-16831878
]
James DeFelice commented on MESOS-9762:
---------------------------------------
I love the spirit of this ticket. A few nits:
1. The "mesos-" prefix feels redundant. Can you elaborate on why this might be
needed? If the idea is that a plugin (or set of plugins) might be serving more
than just Mesos (or more than one mesos cluster), then I'd rather handle that
via plugin runtime configuration vs arbitrary prefixing.
2. I'd like the framework-generated portion to come first. Assuming that Mesos
will never actually be parsing this string (and it shouldn't need to) then the
mesos-generated portion serves as a "variant" factor in the "namespace"
declared by the framework portion. It's also nice to grep for tokens that start
with some prefix (like a framework operation ID, which might actually be the
whole token!) vs. some that start with it and others that end with it.
Presumably frameworks will log their generated operation ID in the same manner
in which it's issued to Mesos as part of an offer operation. Suggested format:
{{<framework-specified-operation-id>.<base64-rawurlencodingnopadding(mesos-operation-uuid)>}}
3. base64-urlsafe-encode: we'd be encoding the raw bytes of the UUID, not the
stringified version of it - right? i'm assuming this is how you arrived at "29
characters" in the desc.
4. base64-urlsafe-encode would be w/o padding, right? (please)
> Encode framework-specified operation ID into CSI volume name.
> -------------------------------------------------------------
>
> Key: MESOS-9762
> URL: https://issues.apache.org/jira/browse/MESOS-9762
> Project: Mesos
> Issue Type: Improvement
> Components: storage
> Reporter: Chun-Hung Hsiao
> Priority: Major
>
> Currently, SLRP uses the internally-generated operation UUID as CSI volume
> creation name, which brings extra difficulty for debugging because users have
> to go through logs to figure out the operation UUID for a given
> {{CREATE_DISK}} call.
> Instead, we could encode the framework-specified operation ID into the volume
> name. To ensure the uniqueness of each volume name, we can use the following
> schema:
> {noformat}
> mesos-<base64-urlsafe-encode(operation-uuid)>.<framework-specified-operation-id>{noformat}
> The prefix before the framework-specified operation ID would be 29 characters
> long.
> We can consider not having the {{mesos-}} prefix to even shorten it, but it
> might not be a bad idea to have that prefix reserved for Mesos.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
