[
https://issues.apache.org/jira/browse/MESOS-9807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864551#comment-16864551
]
Meng Zhu commented on MESOS-9807:
---------------------------------
{noformat}
commit ceb1120e8c53771219363e0bf579a770b914a592
Author: Meng Zhu <[email protected]>
Date: Thu Jun 6 16:18:45 2019 -0700
Used the new quota struct for the allocator recover call.
Review: https://reviews.apache.org/r/70804
commit 4bdbd8e7da5063d55726b628b5e0d31c79650d3f
Author: Meng Zhu <[email protected]>
Date: Thu Jun 6 15:58:05 2019 -0700
Added `Metrics::updateQuota` for quota metrics.
This intends to replace the existing ``Metrics::setQuota` and
`Metrics::remove` calls.
Currently, it only tracks guarantees. Need to add limits metrics.
Review: https://reviews.apache.org/r/70802
commit 495162eefa12900b3a74bfbb269851473df4cce9
Author: Meng Zhu <[email protected]>
Date: Wed Jun 5 14:04:53 2019 -0700
Refactored allocator with the new quota wrapper struct.
This patch also introduces a constant `DEFAULT_QUOTA`.
By default, a role has no guarantees and no limits.
Review: https://reviews.apache.org/r/70801
commit 75798445f932f1f163a502e2325e76cf33450836
Author: Meng Zhu <[email protected]>
Date: Tue Jun 4 10:48:51 2019 -0700
Refactored quota overcommit check.
This refactor makes the `QuotaTree` to use the new
quota wrapper struct.
Also refactor the check to reflect that it is currently
only checking guarantees.
Review: https://reviews.apache.org/r/70800
commit f05f0616841bd539a8b6abfc591f3c287ad998d9
Author: Meng Zhu <[email protected]>
Date: Tue Jun 4 17:34:52 2019 -0700
Added a wrapper struct for quota guarantees and limits.
This struct is temporarily named to `Quota2` to differentiate
with the existing `Quota` struct. It will replace all `Quota`
and rename to `Quota`.
Review: https://reviews.apache.org/r/70799
{noformat}
> Introduce a `struct Quota` wrapper.
> -----------------------------------
>
> Key: MESOS-9807
> URL: https://issues.apache.org/jira/browse/MESOS-9807
> Project: Mesos
> Issue Type: Improvement
> Components: allocation
> Reporter: Meng Zhu
> Assignee: Meng Zhu
> Priority: Major
> Labels: resource-management
>
> We should introduce:
> struct Qutota {
> ResourceQuantities guarantees;
> ResourceLimits limits;
> }
> There are a couple of small hurdles. First, there is already a struct Quota
> wrapper in "include/mesos/quota/quota.hpp", we need to deprecate that first.
> Second, `ResourceQuantities` and `ResourceLimits` are right now only used in
> internal headers. We probably want to move them into public header, since
> this struct will also be used in allocator interface which is also in the
> public header. (Looking at this line, the boundary is alreayd breached:
> https://github.com/apache/mesos/blob/master/include/mesos/allocator/allocator.hpp#L41)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
