[ 
https://issues.apache.org/jira/browse/MESOS-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890778#comment-16890778
 ] 

Benjamin Bannier commented on MESOS-9901:
-----------------------------------------

[~mzhu], could you document the expected behavior? AFAICT we already e.g., test 
that output produced by {{JSON::protobuf}} can be parsed back to proto maps, 
see {{ProtobufTest.JsonifyMap}} in {{3rdparty/stout/tests/protobuf_tests.cpp}}. 
If we do any changes there we should make sure to not break our JSON API.

> Specialize jsonify for protobuf Maps.
> -------------------------------------
>
>                 Key: MESOS-9901
>                 URL: https://issues.apache.org/jira/browse/MESOS-9901
>             Project: Mesos
>          Issue Type: Improvement
>          Components: json api
>            Reporter: Meng Zhu
>            Priority: Major
>
> Jsonify current treats protobuf as a regular repeated field. For example, for 
> the schema 
> {noformat}
> message QuotaConfig {
>   required string role = 1;
>   map<string, Value.Scalar> guarantees = 2;
>   map<string, Value.Scalar> limits = 3;
> }
> {noformat}
> it will produce:
> {noformat}
>       "configs": [
>         {
>           "role": "role1",
>           "guarantees": [
>             {
>               "key": "cpus",
>               "value": {
>                 "value": 1
>               }
>             },
>             {
>               "key": "mem",
>               "value": {
>                 "value": 512
>               }
>             }
>           ]
> {noformat}
> This output cannot be parsed back to proto messages. We need to specialize 
> jsonify for Maps type. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to