[
https://issues.apache.org/jira/browse/MESOS-9630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896520#comment-16896520
]
Benjamin Bannier edited comment on MESOS-9630 at 8/16/19 7:43 PM:
------------------------------------------------------------------
Reviews:
https://reviews.apache.org/r/70096/
https://reviews.apache.org/r/71203/
https://reviews.apache.org/r/71204/
https://reviews.apache.org/r/71299/
https://reviews.apache.org/r/71205/
https://reviews.apache.org/r/71206/
https://reviews.apache.org/r/71207/
https://reviews.apache.org/r/71208/
https://reviews.apache.org/r/71209/
To be submitted when above chain has been submitted for some time:
https://reviews.apache.org/r/71300/
was (Author: bbannier):
Reviews:
https://reviews.apache.org/r/70096/
https://reviews.apache.org/r/71203/
https://reviews.apache.org/r/71204/
https://reviews.apache.org/r/71205/
https://reviews.apache.org/r/71206/
https://reviews.apache.org/r/71207/
https://reviews.apache.org/r/71208/
https://reviews.apache.org/r/71209/
> Consider moving linter setup to pre-commit
> ------------------------------------------
>
> Key: MESOS-9630
> URL: https://issues.apache.org/jira/browse/MESOS-9630
> Project: Mesos
> Issue Type: Wish
> Reporter: Benjamin Bannier
> Assignee: Benjamin Bannier
> Priority: Minor
>
> Mesos currently uses a mix of hand-crafted git commit hooks and mesos-style
> to perform linting. While this has served us well our current approach also
> has some drawbacks, e.g.,
> * the linter setup is spread between hooks and {{support/mesos-style.py}}
> * adding new linters can be cumbersome
> * mesos-style.py uses a process where it creates a single virtualenv to
> install linters in which is tie d to the source tree
> * linter dependencies are only cached to an extent and it is easy to run
> into a situation where one needs to update linter dependencies over the
> network even though one has successfully linted a revision before
> * {{support/mesos-style.py}} lacks a number of features, e.g., running over
> only staged files, running linters in parallel for improved throughput,
> running only specific linters or disabling certain linters, and the
> parameterization of the linters is strongly coupled to implementation of the
> style checker itself.
> The [pre-commit tool|https://pre-commit.com/] solves most of these issues and
> using it in Mesos would not only allow us to get rid of tooling which is hard
> to maintain, but also unlock other features. It is licensed under a MIT
> license. We should consider moving our linting setup over to pre-commit.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
