[ 
https://issues.apache.org/jira/browse/MESOS-9896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970596#comment-16970596
 ] 

Benjamin Mahler commented on MESOS-9896:
----------------------------------------

Started a thread here on their mailing list:
[https://groups.google.com/forum/#!topic/protobuf/4qmUqGE5-oQ]

> Consider using protobuf provided json conversion facilities rather than 
> custom ones.
> ------------------------------------------------------------------------------------
>
>                 Key: MESOS-9896
>                 URL: https://issues.apache.org/jira/browse/MESOS-9896
>             Project: Mesos
>          Issue Type: Task
>          Components: stout
>            Reporter: Benjamin Mahler
>            Priority: Major
>              Labels: foundations
>
> Currently, stout provides custom JSON to protobuf conversion facilities, some 
> of which use protobuf reflection.
> When upgrading protobuf to 3.7.x in MESOS-9755, we found that the v0 /state 
> response of the master slowed down, and it appears to be due to a performance 
> regression in the protobuf reflection code.
> We should file an issue with protobuf, but we should also look into using the 
> json conversion code that protobuf provides to see if that can help avoid the 
> regression. It may be the case that using the built-in facilities actually 
> provides a significant performance benefit, given they don't use reflection.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to