[ 
https://issues.apache.org/jira/browse/MESOS-10097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037097#comment-17037097
 ] 

Andrei Sekretenko commented on MESOS-10097:
-------------------------------------------

{noformat}
commit 2113b76b861af1233151d1a64117795d18b0c3eb
Author: Andrei Sekretenko <[email protected]>
Date:   Thu Feb 13 12:39:24 2020 +0100

    Fixed HTTP framework disconnection/removal to terminate heartbeater.
    
    This patch gets rid of idle-looping heartbeater processes
    that previously could occur after HTTP framework disconnection
    (see MESOS-10097).
    
    Review: https://reviews.apache.org/r/72130
{noformat}

> After HTTP framework disconnects, heartbeater idle-loops instead of being 
> deleted.
> ----------------------------------------------------------------------------------
>
>                 Key: MESOS-10097
>                 URL: https://issues.apache.org/jira/browse/MESOS-10097
>             Project: Mesos
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 1.5.3, 1.6.2, 1.7.2, 1.8.1, 1.9.0, 1.10
>            Reporter: Andrei Sekretenko
>            Assignee: Andrei Sekretenko
>            Priority: Minor
>
> In some cases, Master closes connection of HTTP framework without deleting 
> the heartbeater:
> https://github.com/apache/mesos/blob/65e18bef2c5ff356ef74bac9aa79b128c5b186d9/src/master/master.cpp#L3323
> https://github.com/apache/mesos/blob/65e18bef2c5ff356ef74bac9aa79b128c5b186d9/src/master/master.cpp#L10910
> It can be argued that this does not constitute a leak, because old 
> heartbeaters are deleted on reconnection/removal.
> However, this means that for each disconnected framework there is a 
> ResponseHeartbeaterProcess that performs an idle loop.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to