[
https://issues.apache.org/jira/browse/METRON-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15979212#comment-15979212
]
ASF GitHub Bot commented on METRON-873:
---------------------------------------
GitHub user cestella reopened a pull request:
https://github.com/apache/incubator-metron/pull/542
METRON-873: Stellar string literals do not support quote escaping
## Contributor Comments
Right now, in stellar, we cannot represent a string literal that contains
`'foo'` if the string is quoted with `'` or `"foo"` if the string is quoted
with `"`. This is unfortunate and should be corrected.
To test this out, start up the stellar REPL in fulldev *or* run it locally
by running `mvn exec:java
-Dexec.mainClass="org.apache.metron.common.stellar.shell.StellarShell"` from
`metron-platform/metron-common` and try the following strings:
* `'\'foo\''` should yield `'foo'`
* `"\"foo\""` should yield `"foo"`
* `TO_UPPER('\'foo\'')` should yield `'FOO'`
* `TO_UPPER("\"foo\"")` should yield `"FOO"`
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron (Incubating).
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
bin/generate-md.sh
mvn site:site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron
stellar_quoted_strings
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/542.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #542
----
commit cde9211b5bf7aa3ed4b91477605bbe6685540c71
Author: cstella <ceste...@gmail.com>
Date: 2017-04-21T16:13:18Z
Add quote escaping to Stellar string literals.
commit 2920faaf24385330dab2a8490d7a599ab9aae822
Author: cstella <ceste...@gmail.com>
Date: 2017-04-21T16:34:29Z
Documentationc hange.
commit 88338f110a5db945cb6ea1a99221cb2c6d49633c
Author: cstella <ceste...@gmail.com>
Date: 2017-04-21T17:41:11Z
Cleaned up grammar a bit and added proper support for backslash.
commit f123ddf711e237f60a9bff140a6c47c4dc39fa53
Author: cstella <ceste...@gmail.com>
Date: 2017-04-21T17:45:03Z
missed newlines
commit 0a2284c97c15ec0c1243156f3214fc3beadabea3
Author: cstella <ceste...@gmail.com>
Date: 2017-04-21T18:06:11Z
Updated for bug and to add \n, \t and \r
----
> Stellar string literals do not support quote escaping
> -----------------------------------------------------
>
> Key: METRON-873
> URL: https://issues.apache.org/jira/browse/METRON-873
> Project: Metron
> Issue Type: Improvement
> Reporter: Casey Stella
>
> Right now, in stellar, we cannot represent a string literal that contains
> 'foo' if the string is quoted with ' or "foo" if the string is quoted with ".
> This is unfortunate and should be corrected.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
