[
https://issues.apache.org/jira/browse/METRON-902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989017#comment-15989017
]
ASF GitHub Bot commented on METRON-902:
---------------------------------------
GitHub user JonZeolla opened a pull request:
https://github.com/apache/incubator-metron/pull/555
METRON-902
## Contributor Comments
It appears that `bro_index.template` regressed a bit when it was migrated
to the ambari mpack. If you run this up in vagrant and let the bro sensor-stub
run for a while you will see ES indexing issues for dns logs because answers is
not always an IP address. This fixes that, and I will try to get a look at the
whole bro ES indexing template for other issues, as a part of METRON-348.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [X] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [X] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [X] Have you included steps or a guide to how the change may be verified
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been
executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [ ] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JonZeolla/incubator-metron METRON-902
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/555.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #555
----
commit c5955b37287e5e41acb6803de90d7f8705192bf1
Author: Jon Zeolla <zeo...@gmail.com>
Date: 2017-04-25T13:47:17Z
METRON-883
commit ce055a0cab444ca92f4f80fa0f6f0adde8c20ab5
Author: Jon Zeolla <zeo...@gmail.com>
Date: 2017-04-28T15:20:48Z
Merge branch 'master' of https://github.com/apache/incubator-metron
commit e00f11807c050c768e3906d754f16583d68ddbe1
Author: Jon Zeolla <zeo...@gmail.com>
Date: 2017-04-28T15:30:23Z
METRON-902 ES improperly indexes Bro logs
----
> ES improperly indexes Bro logs
> ------------------------------
>
> Key: METRON-902
> URL: https://issues.apache.org/jira/browse/METRON-902
> Project: Metron
> Issue Type: Bug
> Reporter: Jon Zeolla
> Assignee: Jon Zeolla
>
> It appears that an old issue has been reintroduced into the ES template for
> indexing bro DNS logs. It is possible that other issues have been
> reintroduced as well, as I have not yet reviewed the template holistically.
> Initial fix:
> https://github.com/apache/incubator-metron/blob/4bfb09c49fbc6204ce8b826887d99beff414f84a/metron-deployment/roles/metron_elasticsearch_templates/files/es_templates/bro_index.template#L165-L167
> Reintroduction:
> https://github.com/apache/incubator-metron/blob/125dbef1e59ff808a62e4f5a7d265aafbcf6bf08/metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/0.2.0BETA/package/files/bro_index.template#L165-L167
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
